This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: Bumping DATESTAMP (was: GCC 4.3.5 Status Report (2010-05-22))
On Feb 2, 2011, at 8:32 AM, Richard Guenther wrote:
> On Wed, Feb 2, 2011 at 2:29 PM, Jakub Jelinek <jakub@redhat.com> wrote:
>> On Tue, Feb 01, 2011 at 04:32:51PM +0100, Gerald Pfeifer wrote:
>>> On Tue, 1 Feb 2011, Dongsheng Song wrote:
>>>>> The DATESTAMP change could also be in a post-commit hook (doing
>>>>> nothing if the date didn't change, of course). No idea whether
>>>>> this is technically possible of course.
>>>> Yes, the post-commit hook can do this task.
>>>> If we really want to do that, I can update the current post-commit
>>>> hook script [1].
>>>
>>> I'd love to see that and will be happy to work on this with you,
>>> apply a patch, etc.
>>>
>>> Let's give others the chance to chime in, and if there are no
>>> objections within the next two days, let's proceed. Fair?
>>
>> I'd say it should go into a pre-commit hook instead of
>> post-commit, if possible. So that when one checks in some particular
>> revision DATESTAMP already has the right timestamp.
>
> I wonder if it can go into the same commit even?
No. Subversion specifically documents the fact that a pre-commit hook can't change the transaction; it can only inspect it.
paul