This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: Submitting patches for FreeBSD amd64
- From: Andrew Haley <aph at redhat dot com>
- To: gcc at coreland dot ath dot cx
- Cc: gcc at gcc dot gnu dot org
- Date: Tue, 30 Jun 2009 17:37:50 +0100
- Subject: Re: Submitting patches for FreeBSD amd64
- References: <20090630163550.GC28409@logik.internal.network>
gcc@coreland.ath.cx wrote:
> Hello.
>
> I opened this issue a while back:
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40310
>
> I was told that I needed to run the test suite in order for the patches
> to be accepted. I had trouble getting the test suite to run but have
> now managed (turned out to be a problem specific to my system setup).
>
> Unfortunately, there are a number of unexpected failures. I believe
> these failures to be specific to FreeBSD and have done my best to verify
> that my changes don't affect the results (in other words, I almost
> certain that my changes don't break gcc any more than it already is on
> this platform).
>
> Is this sufficient testing for the patches to be accepted?
Yes. As long as your patch doesn't cause regressions, that's OK.
It might be a good idea to make sure we have bug reports for the failures.
Andrew.