Re: Options of fixing biggest alignment in PR target/38736

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Wed, Jan 7, 2009 at 8:30 AM, Ian Lance Taylor <iant@google.com> wrote:
> "H.J. Lu" <hjl.tools@gmail.com> writes:
>
>> Fixing BIGGEST_ALIGNMENT to 16 may require extensive changes.
>> I am thinking to add DEFAULT_ALIGNMENT with
>>
>> #ifndef DEFAULT_ALIGNMENT
>> #define DEFAULT_ALIGNMENT BIGGEST_ALIGNMENT
>> #endif
>>
>> and use it only for attribute((aligned)).
>
> This does need to be done, but DEFAULT_ALIGNMENT is a poorly chosen
> name.  It should be something more like ATTRIBUTE_ALIGNED_VALUE.
>
> Ian
>

Here is a patch to implement ATTRIBUTE_ALIGNED_VALUE.  OK for trunk?

Thanks.

-- 
H.J.
---
gcc/

2009-01-07  H.J. Lu  <hongjiu.lu@intel.com>

	PR target/38736
	* c-common.c (handle_aligned_attribute): Use
	ATTRIBUTE_ALIGNED_VALUE instead of ATTRIBUTE_ALIGNED_VALUE for
	default alignment value.

	* defaults.h (ATTRIBUTE_ALIGNED_VALUE): New.
	* config/i386/i386.h (ATTRIBUTE_ALIGNED_VALUE): Likewise.

	* doc/extend.texi: Update __attribute__ ((aligned)) with
	ATTRIBUTE_ALIGNED_VALUE.

	* doc/tm.texi: Document ATTRIBUTE_ALIGNED_VALUE.

gcc/testsuite/

2009-01-07  H.J. Lu  <hongjiu.lu@intel.com>

	PR target/38736
	* g++.dg/other/pr38736-1.C: New.
	* g++.dg/other/pr38736-2.C: Likewise.
	* gcc.target/i386/pr38736-1.c: Likewise.
	* gcc.target/i386/pr38736-2.c: Likewise.

Attachment: gcc-aligned-1.patch
Description: Text document