This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Testcases executed, even if graphite is not available
On Wed, Sep 03, 2008 at 11:19:37AM -0700, Andrew Pinski wrote:
> On Wed, Sep 3, 2008 at 11:06 AM, Sebastian Pop <sebpop@gmail.com> wrote:
> > On Tue, Sep 2, 2008 at 8:42 PM, Tobias Grosser
> > <grosser@fim.uni-passau.de> wrote:
> >> It seems this code is already there, but the check for
> >> "check_effective_target_fgraphite" fails. I attached a patch. Now the
> >> graphite test cases are only executed, if graphite is available.
> >>
> >
> > The patch looks good: the code of -fgraphite will only be executed at
> > -O1 or higher, so when -fgraphite is used at -O0 there is no warning.
> > Note that I cannot approve the commit of this patch.
>
> Maybe it is better to error out if -fgraphite is used even without
> optimization if the compiler does not have the required libraries.
>
I think that this is sensible considering that cloog is only
available through a git repository. Requiring people to install
git to build cloog is somewhat un-user-friendly.
--
Steve