This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Testcases executed, even if graphite is not available

From: "Andrew Pinski" <pinskia at gmail dot com>
To: "Sebastian Pop" <sebpop at gmail dot com>
Cc: "Tobias Grosser" <grosser at fim dot uni-passau dot de>, janis187 at us dot ibm dot com, "Joseph S. Myers" <joseph at codesourcery dot com>, "Steve Kargl" <sgk at troutmask dot apl dot washington dot edu>, gcc at gcc dot gnu dot org, "GCC Patches" <gcc-patches at gcc dot gnu dot org>
Date: Wed, 3 Sep 2008 11:19:37 -0700
Subject: Re: [PATCH] Testcases executed, even if graphite is not available
References: <20080902204940.GA90764@troutmask.apl.washington.edu> <1220389027.81857.2.camel@localhost> <Pine.LNX.4.64.0809022122240.32397@digraph.polyomino.org.uk> <1220392468.6577.18.camel@janis-laptop> <1220406129.81857.23.camel@localhost> <cb9d34b20809031106k19b36d5dvc937e26c53fbd4b9@mail.gmail.com>

On Wed, Sep 3, 2008 at 11:06 AM, Sebastian Pop <sebpop@gmail.com> wrote:
> On Tue, Sep 2, 2008 at 8:42 PM, Tobias Grosser
> <grosser@fim.uni-passau.de> wrote:
>> It seems this code is already there, but the check for
>> "check_effective_target_fgraphite" fails. I attached a patch. Now the
>> graphite test cases are only executed, if graphite is available.
>>
>
> The patch looks good: the code of -fgraphite will only be executed at
> -O1 or higher, so when -fgraphite is used at -O0 there is no warning.
> Note that I cannot approve the commit of this patch.

Maybe it is better to error out if -fgraphite is used even without
optimization if the compiler does not have the required libraries.

Thanks,
Andrew Pinski

Follow-Ups:
- Re: [PATCH] Testcases executed, even if graphite is not available
  - From: Steve Kargl
- Re: [PATCH] Testcases executed, even if graphite is not available
  - From: Sebastian Pop

References:
- graphite regressions of trunk
  - From: Steve Kargl
- Re: graphite regressions of trunk
  - From: Tobias Grosser
- Re: graphite regressions of trunk
  - From: Joseph S. Myers
- Re: graphite regressions of trunk
  - From: Janis Johnson
- [PATCH] Testcases executed, even if graphite is not available
  - From: Tobias Grosser
- Re: [PATCH] Testcases executed, even if graphite is not available
  - From: Sebastian Pop

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]