This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Testcases executed, even if graphite is not available


On Tue, 2008-09-02 at 22:42 -0300, Tobias Grosser wrote:
> On Tue, 2008-09-02 at 14:54 -0700, Janis Johnson wrote:
> > On Tue, 2008-09-02 at 21:23 +0000, Joseph S. Myers wrote:
> > > On Tue, 2 Sep 2008, Andrew Pinski wrote:
> > > 
> > > > On Tue, Sep 2, 2008 at 2:15 PM, Tobias Grosser
> > > > <grosser@fim.uni-passau.de> wrote:
> > > > 
> > > > > May be you missed to add "--with-cloog" or "--with-ppl" to
> > > > > your ./configure.
> > > > > Can you send me your config.log file?
> > > > 
> > > > I thought we had decided that the build would fail to happen if the
> > > > person did not have cloog and ppl installed?
> > > 
> > > No, we decided that for 4.4 the Graphite features would be optional, with 
> > > errors if you use any option that would enable Graphite, *and the 
> > > testsuites would quietly disable all Graphite tests if Graphite support 
> > > was not built in*.  It seems this last part is missing or buggy.
> > 
> > Right, gfortran.dg/graphite/graphite.exp should have code like that in
> > gcc.dg/graphite/graphite.exp:
> > 
> >   if ![check_effective_target_fgraphite] {
> >     return
> >   }
> 
> It seems this code is already there, but the check for
> "check_effective_target_fgraphite" fails. I attached a patch. Now the
> graphite test cases are only executed, if graphite is available.

This is OK.

Janis


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]