This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] caret diagnostics
- From: Paolo Bonzini <bonzini at gnu dot org>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: Chris Lattner <clattner at apple dot com>, Robert Dewar <dewar at adacore dot com>, Manuel López-Ibáñez <lopezibanez at gmail dot com>, Tom Tromey <tromey at redhat dot com>, Aldy Hernandez <aldyh at redhat dot com>, dberlin at dberlin dot org, jakub at redhat dot com, gcc at gcc dot gnu dot org, gdr at integrable-solutions dot net, Gcc Patch List <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 16 Aug 2008 19:19:00 +0200
- Subject: Re: [PATCH] caret diagnostics
- References: <6c33472e0808140340o2a56b9f4n149025bfa8426331@mail.gmail.com> <Pine.LNX.4.64.0808141209170.24903@digraph.polyomino.org.uk> <6c33472e0808140527i158255d9hdbc677bd0870cbc1@mail.gmail.com> <Pine.LNX.4.64.0808141234450.24903@digraph.polyomino.org.uk> <6c33472e0808140556y1f8975boaf41babaeec39f98@mail.gmail.com> <Pine.LNX.4.64.0808141338160.25519@digraph.polyomino.org.uk> <6c33472e0808140741hb83b278jad9b1a5b15e8ab02@mail.gmail.com> <48A4468B.3050605@adacore.com> <6c33472e0808140822n3006c740ke28463a18951677b@mail.gmail.com> <48A44F37.4040106@adacore.com> <Pine.LNX.4.64.0808141543560.26025@digraph.polyomino.org.uk> <4DBA62D5-9ABC-433A-A34E-B0295E2C658F@apple.com> <48A6C0BB.20300@gnu.org> <Pine.LNX.4.64.0808161607590.26019@digraph.polyomino.org.uk>
I don't know why it was considered bad (and had thought it was simply
never reviewed), but I am happy to review such patches as i18n maintainer
(including in Stage 3 - they are clearly bug fixes) if the front-end
maintainers don't reject them. However, I think they would need splitting
up for review.
Yes, of course. Unfortunately I don't have much time for submitting
patches at all... :-( I'll take note though of your kind offer to
review this kind of patch.
I'm not convinced by the cp-i18n.c approach, however, although there may
be cases where it's necessary.
I see. In fact, the main problem was about the cp-i18n.c file in the
old review (I *think* by Geoff Keating, but I'm not sure).
My preference would be to use full
sentences if at all possible (see the WARN_FOR_ASSIGNMENT macro in the C
front end and other diagnostics in convert_for_assignment, for example, or
readonly_error for another such case).
Yes, I know about them. I would also prefer to have full sentences when
possible.
Paolo