This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: Please, do not use the merged revisions log as the commit message when merging
2008/8/16 Christopher Faylor <me@cgf.cx>:
> On Sat, Aug 16, 2008 at 02:35:08PM +0200, Manuel L?pez-Ib??ez wrote:
>>Dear GCC devs,
>>
>>Please do *not* use the full logs of the merged revisions as the
>>commit message of a merge. Apart from making the output of svn log
>>useless, commits messages are parsed are tracked for PR numbers, the
>>commit message is added to the bugzilla page of the PR and people
>>subscribed to the relevant PR in bugzilla are notified of the commit.
>>Therefore a single merge of many revisions would result in a flood of
>>mails sent for no good reason and they make a mess of the bugzilla
>>page.
>>
>>I am sure many of you have been hit by this recently. Please, let's
>>try to avoid this.
>
> If that isn't a good enough reason, doing this completely swamps
> gcc.gnu.org as it valiantly attempts to send all of the above email.
> This resulted in a load average of 24 on the system last night and kept
> me awake until 2:30AM trying to stabilize things.
Could we put a limit to the commit log entry? More than 500 hundred
lines changelog entries should just be rejected and this will avoid
someone accidentally committing a full log or a diff or just random
junk.
I am willing to try to implement this if I can get access to the
pre-commit scripts of our subversion server. I will also propose to
reject any attempt to move or delete or rename trunk (this has
happened a few times already and it is annoying).
I would also propose that we enable revision property modification, so
people that have sent a broken commit message are able to fix them[*].
I personally use or grep 'svn log' a lot, and wrong messages are a
pain.
See the output of svn log -r138275
[*] http://subversion.tigris.org/faq.html#change-log-msg
Cheers,
Manuel.