This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] caret diagnostics
- From: "Manuel López-Ibáñez" <lopezibanez at gmail dot com>
- To: "Mark Mitchell" <mark at codesourcery dot com>
- Cc: "Robert Dewar" <dewar at adacore dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>, "Tom Tromey" <tromey at redhat dot com>, "Aldy Hernandez" <aldyh at redhat dot com>, dberlin at dberlin dot org, jakub at redhat dot com, gcc at gcc dot gnu dot org, gdr at integrable-solutions dot net, "Chris Lattner" <clattner at apple dot com>, "Gcc Patch List" <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 14 Aug 2008 20:59:40 +0200
- Subject: Re: [PATCH] caret diagnostics
- References: <6c33472e0808140340o2a56b9f4n149025bfa8426331@mail.gmail.com> <Pine.LNX.4.64.0808141209170.24903@digraph.polyomino.org.uk> <6c33472e0808140527i158255d9hdbc677bd0870cbc1@mail.gmail.com> <Pine.LNX.4.64.0808141234450.24903@digraph.polyomino.org.uk> <6c33472e0808140556y1f8975boaf41babaeec39f98@mail.gmail.com> <Pine.LNX.4.64.0808141338160.25519@digraph.polyomino.org.uk> <6c33472e0808140741hb83b278jad9b1a5b15e8ab02@mail.gmail.com> <48A4468B.3050605@adacore.com> <6c33472e0808140822n3006c740ke28463a18951677b@mail.gmail.com> <48A47CD0.9020802@codesourcery.com>
2008/8/14 Mark Mitchell <mark@codesourcery.com>:
> Manuel López-Ibáñez wrote:
>
>> My proposal is to enable this while not in release mode (like we
>> enable checks and dump statistics and output from the optimizers), so
>> developers notice wrong locations and open a PR and maybe even fix
>> them.
>
> Manuel --
>
> We can all work together, but the approach of "break the compiler and hope
> that other developers will fix it" is not a good plan. As Joseph says, this
> needs to be configured off by default (for compatibility with the way GCC
> has worked since forever, and for compatibility with the GNU standards), and
> there needs to be an option to turn it on. You will need to recruit others
> who are willing to invest in helping to improve the new mode's quality.
The locations are as wrong now as they will be after enabling caret
diagnostics. The only difference is that no one pays attention right
now because that would require to enable -fshow-column and count
column numbers. So I am certainly not "breaking the compiler and
hoping that other developers will fix it". This is *exactly* like
printing statistics at the end of the compilation. It may hint you
that something is broken somewhere but you can freely ignore it as a
visual hassle of the experimental compiler.
BTW, all those time/memory statistics didn't break anything when they
were added? And they are given even if no error/warning is printed.
Cheers,
Manuel.