This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] caret diagnostics (was: broken FE diagnostics wrt complex expressions)
2008/8/14 Joseph S. Myers <joseph@codesourcery.com>:
> On Thu, 14 Aug 2008, Manuel López-Ibáñez wrote:
>
>> It is controlled by -fdiagnostics-show-caret. See the diff for gcc/opts.c.
>>
>> The configure options are meant to enable/disable all code related to
>> caret printing in a similar way as it was done with mapped locations.
>> This was requested the first time I sent this patch because it was
>> considered too experimental to have it even with
>> -fno-diagnostics-show-caret as the default.
>
> Mapped locations were sitting around on trunk for a long time as a
> bitrotten feature; I don't think that's a good example here. When the
> code works and passes review it should go on trunk, default remaining the
> present diagnostic style according to the GNU Coding Standards, no
> configure option.
That is nice to know *after* wasting all that time figuring out how
configure works [*], ;-)
Even if the configure options do not control the compilation of the
code, they should at least control the default. I think that, at least
for development versions, the default should be on. We do want
developers to realise when their new warning/error is pointing to the
wrong location. Moreover, some user-friendly distributions may want to
enable this by default. Therefore, I would argue to keep the configure
options to determine the default value of -fdiagnostics-show-caret.
Cheers,
Manuel.
[*] BTW, thanks to Basile Starynkevitch for writing
http://gcc.gnu.org/wiki/Regenerating_GCC_Configuration