Re: C++ Warnings on trunk

[Ian Lance Taylor <iant at google dot com>]

NightStrike <nightstrike@gmail.com> writes:

> On 7/8/08, Ian Lance Taylor <iant@google.com> wrote:
>> NightStrike <nightstrike@gmail.com> writes:
>>
>> > I was under the impression that these would be cleaned up before the
>> > -W options were applied to the trunk.
>>
>> It's pretty hard to clean up all the warnings for every possible
>> target.  Also these are only warnings--this code is not compiled with
>> -Werror.
>>
>> In this case, I argue that this code is always compiled with a C
>> compiler, and should never be compiled by a C++ compiler.  Therefore,
>> I believe it is wrong for this code to be compiled with the
>> -Wc++-compat warning enabled.  This should be fixed somewhere in the
>> configure script and/or Makefile.
>
> Ok.  How about these?
>
> ../../gcc/gcc/bitmap.c: In function 'bitmap_obstack_alloc_stat':
> ../../gcc/gcc/bitmap.c:359: warning: request for implicit conversion
>>From 'void *' to 'struct bitmap_head_def *' not permitted in C++
> ../../gcc/gcc/bitmap.c: In function 'bitmap_obstack_free':
> ../../gcc/gcc/bitmap.c:394: warning: request for implicit conversion
>>From 'void *' to 'struct bitmap_element *' not permitted in C++

Kaveh mentioned these in his original e-mail, explained why he found
it difficult to fix, and added this to the Makefile so that it
wouldn't break the build.

# bitmap.c contains -Wc++compat warnings.
bitmap.o-warn = -Wno-error

This too should be fixed soon but need not be fixed immediately.

Ian