This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: dg-skip-if on powerpc when multiple cpu cflags specified
- From: Joel Sherrill <joel dot sherrill at oarcorp dot com>
- To: "janis187 at us dot ibm dot com" <janis187 at us dot ibm dot com>
- Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, "gcc at gcc dot gnu dot org" <gcc at gcc dot gnu dot org>
- Date: Thu, 24 Apr 2008 18:14:17 -0500
- Subject: Re: dg-skip-if on powerpc when multiple cpu cflags specified
- References: <47D7F58E.2000602@oarcorp.com> <20080312170329.GA29540@lucon.org> <47D812A9.5010001@oarcorp.com> <200803121740.52085.paul@codesourcery.com> <47D81952.6050000@oarcorp.com> <200803121807.m2CI7Hrd033536@makai.watson.ibm.com> <47D81E77.8070603@oarcorp.com> <200803121823.m2CINW5g029444@makai.watson.ibm.com> <47D82BF8.8070908@oarcorp.com> <200803121922.m2CJMm1A031242@makai.watson.ibm.com> <Pine.LNX.4.64.0803121945250.29332@digraph.polyomino.org.uk> <47D9844B.2000905@oarcorp.com> <Pine.LNX.4.64.0803140041540.12948@digraph.polyomino.org.uk> <47DA974C.5030708@oarcorp.com> <1205515315.10653.8.camel@janis-laptop> <1205517268.10653.12.camel@janis-laptop> <480F5C27.5000508@oarcorp.com> <1209076807.12614.23.camel@janis-laptop> <48110FA0.6000706@oarcorp.com> <1209078471.12614.30.camel@janis-laptop>
Janis Johnson wrote:
On Thu, 2008-04-24 at 17:54 -0500, Joel Sherrill wrote:
Not knowing the internal details of the test harness, I
would make an ignorant guess that the command line
should be checked before it is executed. If it has multiple
-mcpu/-march options and they were not all the same, the
test should be skipped.
Is that kind of the logic we need even if the implementation
is way off?
When you put it that way it sounds very simple!
It is easy to say. :-D
Something like
/* { dg-options "-mcpu=xxx" } */
/* { dg-skip-if-incompatible-options } */
where dg-skip-if-incompatible-options starts out by looking for
multiple instances of non-identical -mcpu= or -march= and then
gets refined over time. There's already code in check_flags in
target-supports-dg.exp to gather together all the various flags
that will be used for a test.
This will involve editing every test that using dg-options
to add a -mcpu/-march flag. Would it make sense to let
dg-options check for the conflict as it adds an option?
In my case, the options are added in the board file
this way:
set_board_info cflags "-B${RTEMS_MAKEFILE_PATH}/lib/ -specs bsp_specs
-qrtems -mcpu=603e"
I'll investigate.
Thanks. This is really a precision fix. :-D
Janis
--
Joel Sherrill, Ph.D. Director of Research & Development
joel.sherrill@OARcorp.com On-Line Applications Research
Ask me about RTEMS: a free RTOS Huntsville AL 35805
Support Available (256) 722-9985