This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Regenerating configure scripts

Brian Dessent wrote:
Michael Eager wrote:

I've noticed a problem with the patch:
   if test "${with_newlib+set}" = set; then
     AC_LIBTOOL_DLOPEN
   fi

The test always succeeds.  When $with_newlib is "yes",
${with_newlib+set} is "set".

If I change this to the old style test
   if test "x$with_newlib" = x; then
     AC_LIBTOOL_DLOPEN
   fi
then it works as expected.

This is weird.  I see the former idiom everywhere in configure.
The tests can't all be failing.


I think both are wrong.  You should be testing whether it equals the
value "yes", not whether or not the variable is set, because
$with_newlib can equally be blank or set to "no" in a non-newlib case.

That's a good point and an easy change.

--
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]