This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] BIT_FIELD_REF_UNSIGNED considered harmful

From: Diego Novillo <dnovillo at google dot com>
To: Richard Guenther <rguenther at suse dot de>
Cc: gcc at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
Date: Wed, 05 Mar 2008 07:47:36 -0500
Subject: Re: [PATCH] BIT_FIELD_REF_UNSIGNED considered harmful
References: <Pine.LNX.4.64.0803051312050.4133@zhemvz.fhfr.qr>

On 03/05/08 07:18, Richard Guenther wrote:

Comments?

Makes sense to me.

+ 	      if (INTEGRAL_TYPE_P (TREE_TYPE (t))
+ 		  && (TYPE_PRECISION (TREE_TYPE (t))
+ 		      != TREE_INT_CST_LOW (TREE_OPERAND (t, 1))))
+ 		{
+ 		  error ("integral result type precision does not match "
+ 			 "field size of BIT_FIELD_REF");
+ 		  return t;
+ 		}
+ 	      if (!INTEGRAL_TYPE_P (TREE_TYPE (t))

'else if' here?

Diego.

Follow-Ups:
- Re: [PATCH] BIT_FIELD_REF_UNSIGNED considered harmful
  - From: Manfred Hollstein

References:
- [PATCH] BIT_FIELD_REF_UNSIGNED considered harmful
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]