This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: -Wparentheses lumps too much together

From: Paolo Bonzini <bonzini at gnu dot org>
To: Andreas Schwab <schwab at suse dot de>
Cc: Ian Lance Taylor <iant at google dot com>, Doug Gregor <doug dot gregor at gmail dot com>, jklowden at freetds dot org, gcc-patches at gcc dot gnu dot org, gcc at gnu dot org
Date: Sat, 12 Jan 2008 11:24:13 +0100
Subject: Re: -Wparentheses lumps too much together
References: <20071219200235.GA21525@oak.schemamania.org> <24b520d20801111427r6081fec6k6a4a513e5022c492@mail.gmail.com> <m3hchj3gd0.fsf@localhost.localdomain> <jezlvbmlps.fsf@sykes.suse.de>

Andreas Schwab wrote:

Ian Lance Taylor <iant@google.com> writes:

I'm inclined to approve this if -Wprecedence stays in -Wall, but I'd
like to hear if anybody else has anything to say.


The name of the option is rather poor, IMHO.  -Wparentheses warns about
precedences, so what is the difference to -Wprecedence?

-Wparentheses warns in general about things that the GCS prefer to be parenthesized. I would prefer something like

int warn_precedence = 2;

...

if (warn_precedence == 2)
  warn_precedence = warn_parentheses;

that is, we have

  -Wparentheses remains as is now, and is enabled by -Wall
  -Wparentheses -Wno-precedence only warns about things like a = b = c
                                for bool b and non-bool a

Paolo

References:
- Re: -Wparentheses lumps too much together
  - From: Doug Gregor
- Re: -Wparentheses lumps too much together
  - From: Ian Lance Taylor
- Re: -Wparentheses lumps too much together
  - From: Andreas Schwab

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]