This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: Last argument of lang_hooks_for_callgraph.analzye_tree unused?
- From: Jan Hubicka <jh at suse dot cz>
- To: Diego Novillo <dnovillo at google dot com>
- Cc: Jan Hubicka <jh at suse dot cz>, gcc at gcc dot gnu dot org
- Date: Thu, 1 Nov 2007 17:55:41 +0100
- Subject: Re: Last argument of lang_hooks_for_callgraph.analzye_tree unused?
- References: <b798aad50711010832i2bd73882t5098af229b8e4c2b@mail.gmail.com>
> Jan, I'm converting the call graph builder code for tuples and in the
> process I ran into calls to lang_hooks.callgraph.analyze_expr(). From
> what I've seen:
>
> 1- The third argument to that function (DECL), is not used by any callback.
>
> 2- In fact, if it was used, we'd ICE because the function signature expects
> a tree and we are calling it with a callgraph node.
>
> I'm tempted to just delete the argument. Unless you have a future use for it?
Just go ahead and kill it. I would preffer to remove the whole hook,
but we still keep some non-GIMPLE expressions in static initializers :(
Honza
>
>
> Thanks.