This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: GCC 4.3.0 Status Report (2007-09-04)
Hi,
thanks for looking at the patch.
On Sun, Sep 09, 2007 at 11:42:55AM -0700, Mark Mitchell wrote:
> Martin Jambor wrote:
>
> > Well, there's mine :-) Specifically, its the "Switch initializations
> > conversion:" http://gcc.gnu.org/ml/gcc-patches/2007-09/msg00215.html
>
> Do you have an FSF copyright assignment on file? This patch is big
> enough that we would not be able to include it without that.
Yes, I do, see http://misc.jamborm.net/Jambor305799.pdf
> I see one technical change that should be made. In particular, please
> change:
>
> > +/* We never create arrays larger than the following constant (given in number
> > + of elements). */
> > +#define MAX_ARRAY_RANGE 0x2000
> > +
> > +/* We never create arrays if the number of branches is not at least the range
> > + divided by the following constant. */
> > +#define MAX_RANGE_BRANCH_RATIO 8
>
> to use the --param mechanism. Our policy is to have *no* magic numbers
> for these kinds of things. It's easy enough to allow users to use
> --param to set the values, and that makes it easy for people (often the
> compiler developers themselves) to experiment with the values to help
> fine-tune the defaults.
OK, I have changed the patch accordingly (and added some documentation
that was missing last time) and am currently re-testing it. I expect
to post the new version to the list tonight.
Martin