This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: Comment mismatch in tree-cfg.c:verify_gimple_expr
- From: Richard Guenther <rguenther at suse dot de>
- To: Diego Novillo <dnovillo at google dot com>
- Cc: gcc at gcc dot gnu dot org
- Date: Fri, 31 Aug 2007 16:43:12 +0200 (CEST)
- Subject: Re: Comment mismatch in tree-cfg.c:verify_gimple_expr
- References: <46D81D80.3010207@google.com>
On Fri, 31 Aug 2007, Diego Novillo wrote:
>
> Richard, this comment does not match the code. The code allows type
> conversions between two integral types and between arbitrary types that
> happen to *not* be integral. Which semantics did you mean here?
>
> /* Allow conversions between integral types. */
> if (INTEGRAL_TYPE_P (type) == INTEGRAL_TYPE_P (TREE_TYPE (op)))
> return false;
>
> I'm thinking this should be && not ==.
Whoops. Indeed. Now - no guarantee that this won't "break" anything
of course... (I'll check on the mainline)
Richard.