This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: missing libtool sources?


[ CVS HEAD's ltmain.sh containing as first line:
  # Generated from ltmain.m4sh; do not edit by hand
]

* DJ Delorie wrote on Thu, Aug 02, 2007 at 05:09:09PM CEST:
> 
> > I don't think this is much of a problem.  ltmain.sh is always
> > distributed with libtool and you would need the full libtool sources to
> > rebuild it anyway.
> 
> I was thinking more of the legality of shipping GPL files without
> their sources, being defined as "the preferred form of the work for
> making modifications to it", and since the file says "do not edit this
> file", we're clearly not complying.
> 
> It would be bad form for an FSF project to not comply 100% with the
> GPL.

I think we should adjust the Libtool sources in this case.  While CVS
HEAD's ltmain.sh is generated from ltmain.m4sh, and we prefer patches
against the latter file, the former is definitely in a source code form
that makes modifications just as easy: both are shell scripts without
lots of redundancy (unlike configure scripts).  And the intended mode of
operation is definitely to have the former file distributed rather than
the latter.  IMHO the same holds for the other files generated thusly
from the Makefile.

Would this patch eliminate further doubts?  If no, could you suggest an
improvement?

Thanks,
Ralf

2007-08-06  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>

	* Makefile.am (edit): Do not warn against manual editing for the
	generated files libtool, libtoolize, libltdl/m4/ltversion.m4,
	tests/defs, as they are still in a preferred source code form as
	required by GPL.
	Report by DJ Delorie.

Index: Makefile.am
===================================================================
RCS file: /cvsroot/libtool/libtool/Makefile.am,v
retrieving revision 1.224
diff -u -r1.224 Makefile.am
--- Makefile.am	26 Jul 2007 22:44:39 -0000	1.224
+++ Makefile.am	6 Aug 2007 21:10:34 -0000
@@ -135,7 +135,7 @@
 	-e 's,@pkgdatadir\@,$(pkgdatadir),g' \
 	-e 's,@host_triplet\@,$(host_triplet),g' \
 	-e 's,@prefix\@,$(prefix),g' \
-	-e "s,@configure_input\@,Generated from $$input; do not edit by hand,g"
+	-e "s,@configure_input\@,Generated from $$input.,g"
 
 sh_files	= $(auxdir)/general.m4sh $(auxdir)/getopt.m4sh
 EXTRA_DIST     += bootstrap $(srcdir)/libtoolize.in $(auxdir)/ltmain.m4sh \


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]