This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: tuples: initial infrastructure


On Fri, Apr 20, 2007 at 01:07:14PM -0400, Aldy Hernandez wrote:
> +	    /* There can be 3 types of unary operations:
> +
> +		 SYM = <constant>	<== GSS_ASSIGN_UNARY_REG
> +	         SYM = SYM2		<== GSS_ASSIGN_UNARY_MEM

Um, ssa_name = ssa_name isn't  a memory 

> +/* A sequences of gimple statements.  */
> +#define GS_SEQP_FIRST(S)	(S)->first
> +#define GS_SEQP_LAST(S)		(S)->last
> +#define GS_SEQ_FIRST(S)		(S).first
> +#define GS_SEQ_LAST(S)		(S).last

Why do you have both of these?

Otherwise it looks ok.  I figure you'll want to build a set of
iterators and such for gs_sequences, like for tree-iterator.[ch].


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]