This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Bug in value-prof.c:visit_hist

From: Robert Kidd <rkidd at crhc dot uiuc dot edu>
To: gcc at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
Date: Wed, 7 Feb 2007 13:37:48 -0600
Subject: Bug in value-prof.c:visit_hist

There appears to be a bug in value-prof.c:visit_hist rev 121554. This function always returns 0, which causes htab_traverse to exit early. This means that only the first histogram that appears in cfun- >value_histograms->entries is ever checked, so verify_histograms will only indicate an error if the first histogram is unreachable. The attached patch changes the return value to ensure that all histograms are checked. This patch bootstraps and passes make check on x86_64.

Robert Kidd
rkidd@crhc.uiuc.edu

Attachment: value-prof.patch.txt
Description: Text document

Follow-Ups:
- Re: Bug in value-prof.c:visit_hist
  - From: Eric Botcazou

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]