This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: expand_omp_parallel typo?

From: Gabriel Dos Reis <gdr at integrable-solutions dot net>
To: Marcin Dalecki <martin at dalecki dot de>
Cc: GCC Development <gcc at gcc dot gnu dot org>
Date: 18 Oct 2006 11:06:40 +0200
Subject: Re: expand_omp_parallel typo?
References: <45359552.6070208@codesourcery.com> <74A609EE-9971-4FE4-82B0-457103083A07@dalecki.de>

Marcin Dalecki <martin@dalecki.de> writes:

| Looking at the function expand_omp_parallel in omp-low.c I have found
| the following line of code:
| 
|    bsi_insert_after (&si, t, TSI_SAME_STMT);
| 
| Shouldn't this bee
| 
|    bsi_insert_after (&si, t, BSI_SAME_STMT);
| 
| instead?

The TSI_* and BSI_* enumerators are supposed to have the same numerical
values.  However, either TSI_* or BSI_* should just go away.  From typing
perspective, as Marcin points out, the above is meaningless.
(Yes, I know, C does not care; but closely related languages do).

-- Gaby

References:
- GCC 4.2/4.3 Status Report (2006-10-17)
  - From: Mark Mitchell
- expand_omp_parallel typo?
  - From: Marcin Dalecki

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]