This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: pr27650 - dllimport of virtual methods broken.

From: Mark Mitchell <mark at codesourcery dot com>
To: Danny Smith <dannysmith at clear dot net dot nz>
Cc: 'Carlos O'Donell' <carlos at codesourcery dot com>, gcc at gcc dot gnu dot org, jason at redhat dot com, nathan at codesourcery dot com
Date: Wed, 13 Sep 2006 20:37:41 -0700
Subject: Re: pr27650 - dllimport of virtual methods broken.
References: <000201c6d7a6$4c000310$e86d65da@anykey>

Danny Smith wrote:

The problem I had was with the second case below.  We don't know if a
method is implicitly virtual
until search.c:look_for_overrides_r).  Would t be better to unset
DECL_DLLIMPORT_P (and remove the attribute as well) there?

Ah, right, good point. I always forget that case,.partly because I really think that processing should be done when the function is declared. We can know whether it's virtual at that point, so I think we should. But, that's not how things work now. :-(

So, perhaps the best place would be in check_for_override. That's called for all methods when the class is complete.

Thanks,

--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713

Follow-Ups:
- RE: pr27650 - dllimport of virtual methods broken.
  - From: Danny Smith

References:
- RE: pr27650 - dllimport of virtual methods broken.
  - From: Danny Smith

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]