This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: gcc trunk vs python

From: Paolo Bonzini <paolo dot bonzini at lu dot unisi dot ch>
To: Jack Howarth <howarth at bromo dot msbb dot uc dot edu>
Cc: gcc at gcc dot gnu dot org, mveksler at techunix dot technion dot ac dot il
Date: Thu, 24 Aug 2006 08:10:55 +0200
Subject: Re: gcc trunk vs python
References: <20060824041245.A44A011000B@bromo.msbb.uc.edu>

Jack Howarth wrote:

Andrew,
    Thanks. The change...

--- Python-2.4.3/Objects/intobject.c.org        2006-08-23 23:49:33.000000000 -0400
+++ Python-2.4.3/Objects/intobject.c    2006-08-23 23:52:01.000000000 -0400
@@ -479,7 +479,7 @@
                return DIVMOD_ERROR;
        }
        /* (-sys.maxint-1)/-1 is the only overflow case. */
-       if (y == -1 && x < 0 && x == -x)
+       if (y == -1 && x < 0 && ((unsigned)x) == -(unsigned)x)
                return DIVMOD_OVERFLOW;

or just a much clearer

	if (y == -1 && x == INT_MIN)
		return DIVMOD_OVERFLOW;

(possibly with a #include <limits.h> at the top).

Paolo

Follow-Ups:
- Re: gcc trunk vs python
  - From: Michael Veksler

References:
- Re: gcc trunk vs python
  - From: Jack Howarth

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]