This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
PATCH: Compile options.c with -fcommon
On Tue, May 16, 2006 at 10:41:22AM -0700, Andrew Pinski wrote:
>
> On May 16, 2006, at 10:39 AM, H. J. Lu wrote:
>
> >
> >I assume that -fno-common is added by hand since I didn't see it
> >in my build logs on Linux/x86, Linux/x86-64 and Linux/ia64.
>
> No it is not added by hand. It is used when checking is turned on.
> Now I see you did not have checking on which is wrong for development.
>
Here is a patch to force commoncommon symbols in options.o.
H.J.
---
2006-05-16 H.J. Lu <hongjiu.lu@intel.com>
* Makefile.in (options.o-warn): New. Add -fcommon if needed.
--- gcc/Makefile.in.common 2006-05-16 09:26:43.000000000 -0700
+++ gcc/Makefile.in 2006-05-16 10:57:24.000000000 -0700
@@ -199,6 +199,11 @@ VALGRIND_DRIVER_DEFINES = @valgrind_path
build-warn = $(STRICT_WARN)
GCC_WARN_CFLAGS = $(LOOSE_WARN) $($(@D)-warn) $(NOCOMMON_FLAG) $($@-warn)
+ifeq ($(NOCOMMON_FLAG),-fno-common)
+# options.c needs to define compiler options as common symbols.
+options.o-warn = -fcommon
+endif
+
# These files are to have specific diagnostics suppressed, or are not to
# be subject to -Werror:
# Bison-1.75 output often yields (harmless) -Wtraditional warnings