This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: mips: -G0 vs __dso_handle


DJ Delorie <dj@redhat.com> writes:
> How about this?  Tested under mipsisa64-elf with no regressions.  The
> other two I found by inspection; they're the only other two that have
> .sdata and use -G 0.

Looks good to me FWIW, although I can't approve it.  I wonder if...

> +#if defined(__mips__) || defined(__iq2000__) || defined(__m32r__)
> +extern void *__dso_handle __attribute__ ((__section__ (".sdata")));
> +#endif

...this should be handled by some tm.h macro though, like the other
conditional stuff in crtstuff.c.  I'm not sure there's any precedent
for hard-coding the architectures in crtstuff.c itself.  (Not insisting,
just raising the question.)

Richard


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]