This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: pruning unused debugging types (enums/PR23336)
On Thu, Feb 16, 2006 at 03:40:57PM -0400, Aldy Hernandez wrote:
> + htab_t GTY ((param_is (union tree_node))) used_types_hash;
Should be "tree" not the union. You're storing a pointer,
not the union itself.
> +used_types_insert (tree t, struct function *cfun)
Call it something other than cfun. Don't shadow globals this way.
> + htab_traverse_noresize (cfun->used_types_hash, premark_used_types_helper, NULL);
Shouldn't need to specify noresize.
> @@ -6477,6 +6477,9 @@ store_parm_decls (void)
> /* Initialize the RTL code for the function. */
> allocate_struct_function (fndecl);
>
> + cfun->used_types_hash = htab_create (37, htab_hash_pointer,
> + htab_eq_pointer, NULL);
This should be either done in function.c, or dwarf2out.c should
be prepared for the hash to be null.
r~