This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: [4.1/4.2 Regression]: Miscompiled FORTRAN program
On Wed, 2006-02-15 at 05:52, Denis Nagorny wrote:
> Did I understand your idea correctly? Can you comment new patch version.
> It isn't fully tested but am I going in right direction?
Yes, that is what I was suggesting.
In choose_reload_regs, you only need one regno_clobbered_p call, with
sets == 2, as that will check for both clobbers and REG_INC notes.
There are some indentation problems with the patch. It looks like maybe
you have inconsistent usage of spaces/tabs for indentation, and/or that
your mailer converted the tabs to spaces. You probably should put
patches in a MIME attachment.
In both the reg_inc_found_and_valid_p declaration and definition, there
should be a space before the open parenthesis. Also, the two calls in
regno_clobbered_p have the same problem.
At the end of the reg_inc_found_and_valid_p, there is a spurious blank
line.
--
Jim Wilson, GNU Tools Support, http://www.specifix.com