This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Wrong ChangeLog entries
- From: "Giovanni Bajo" <rasky at develer dot com>
- To: "Mark Mitchell" <mark at codesourcery dot com>
- Cc: <gcc at gcc dot gnu dot org>
- Date: Fri, 29 Jul 2005 10:15:24 +0200
- Subject: Wrong ChangeLog entries
Mark,
- with your commit for PR 20142, you also committed a hunk to name-lookup.c
which is not described in the ChangeLog. It is also unclear whether it is
effectively need for that PR or not, but nonetheless it went in, so the entry
should probably be fixed.
- It is unclear which patch fixed PR 19063, which patch fixed PR 13268, or if
the same patch fixed both.
* Both bugs were closed at the same time, but the ChangeLog entry does not
mention PR 19063. (To add confusion, the original ChangeLog entry mentioned a
totally unrelated bug (17413) instead of PR13268, but that typo was later fixed
in CVS).
* In the testsuite, I cannot find a testcase for PR13268, I can only find a
testcase for PR 19063 (g++.dg/template/crash31.C), and the testcase is also
wrong (contains a typo, so it does not probably test what it was supposed to
test).
* The patch in the mail in gcc-patches
(http://gcc.gnu.org/ml/gcc-atches/2004-12/msg01697.html) adds even more
confusion because it contains the diff for crash31.C but with a different
heading comment (PR c++/13268 instead of PR c++/19063).
If those bugs were duplicates, it should have probably be mentioned in both the
ChangeLog and the bug description; also one should be closed as duplicate of
the other, instead of simply marked as "fixed".
Giovanni Bajo