Re: [PATCH] GCC 3.4.3: libobjc build failure

[Andrew Pinski <pinskia at physics dot uc dot edu>]

On Dec 20, 2004, at 4:48 PM, Denis Zaitsev wrote:

> On Mon, Dec 20, 2004 at 04:38:36PM -0500, Andrew Pinski wrote:
> > On Dec 20, 2004, at 4:35 PM, Denis Zaitsev wrote:
> >
> > > This patch is for exactly the same issue as described in
> > >
> > > http://gcc.gnu.org/ml/gcc/2002-12/msg00033.html
> > >
> > > The fix is exactly the same, just another file is the target.  
> > > Without
> > > it libobjc fails to build when --with-objc-gc is given to configure.
> >
> > This patch is incorrect as noted before.  I am going to reject it
> > as it was rejected before.  Again libobjc has no reason to include
> > these headers.
>
> a) The patches from the reference I've noted are already applied.
Yes and the patch was submitted before, see
<http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12035>.


> b) libobjc is not compiled without the new patch.  How should it be
>    fixed then?

The uses of the macros are not needed as shown by a "grep -r ."

Does this patch fix the problem for you?

Thanks,
Andrew Pinski

Attachment: temp1.diff.txt
Description: Text document