This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: AC_COMPILE_CHECK_SIZEOF
Jones Desougi <jones@ingate.com> writes:
>> Yes, well, mainline is the place for not-simple-one-line-fixes.
>> Although, we are on the threshold of stage 3 of development, so this
>> might be better held for 3.6.
>
> Right, the place but not always.
>
>> Does this bug cause any problems in mainline?
>
> It's a latent bug. Perhaps you do not consider such worth fixing.
When there's no immediate problem, I would prefer to replace it with
the stock AC_CHECK_SIZEOF or else leave it alone.
> The obvious difference between AC_CHECK_SIZEOF and AC_COMPILE_CHECK_SIZEOF
> is that if type is unknown the former sets the size to zero while the latter
> issues an error. AC_CHECK_SIZEOF also has a simple sanity check on its first
> argument, demanding a literal.
> Would you approve a patch that cuts over to AC_CHECK_SIZEOF?
Yes, as long as it comes fairly soon.
zw