This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Mainline space problem


Andrew Pinski wrote:
I found out that the patch which introduced this failure was (which
means it was latent bug):
+2004-09-02  James E Wilson  <wilson@specifixinc.com>
+       * common.opt (ftrapping-math): Default to on.

I checked in the attached patch to fix this. Mainline bootstraps with the patch, but does not bootstrap without it. I have also started a make check, and things look fine so far.


I think the patch that broke it was
http://gcc.gnu.org/ml/gcc-patches/2004-06/msg01881.html
but the problem went unnoticed until now because flag_trapping_math was accidentally turned off earlier.
--
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com
2004-09-06  James E Wilson  <wilson@specifixinc.com>

	* emit-rtl.c (try_split): Check INSN_P before may_trap_p call.

Index: emit-rtl.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/emit-rtl.c,v
retrieving revision 1.410
diff -p -r1.410 emit-rtl.c
*** emit-rtl.c	18 Aug 2004 21:08:20 -0000	1.410
--- emit-rtl.c	6 Sep 2004 20:12:42 -0000
*************** try_split (rtx pat, rtx trial, int last)
*** 3327,3333 ****
  	  while (insn != NULL_RTX)
  	    {
  	      if (CALL_P (insn)
! 		  || (flag_non_call_exceptions
  		      && may_trap_p (PATTERN (insn))))
  		REG_NOTES (insn)
  		  = gen_rtx_EXPR_LIST (REG_EH_REGION,
--- 3327,3333 ----
  	  while (insn != NULL_RTX)
  	    {
  	      if (CALL_P (insn)
! 		  || (flag_non_call_exceptions && INSN_P (insn)
  		      && may_trap_p (PATTERN (insn))))
  		REG_NOTES (insn)
  		  = gen_rtx_EXPR_LIST (REG_EH_REGION,

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]