RE: Problem with insn-conditions.c

["Dave Korn" <dk at artimi dot com>]

> -----Original Message-----
> From: gcc-owner On Behalf Of Zack Weinberg
> Sent: 07 August 2004 19:39
> To: Will Pugh

> Will Pugh writes:
> 
> > Hi,
> >
> > I'm really new to compiling GCC, and ran into a problem where
> > insn-conditions.c contained illegal characters in some of 
> the strings
> > it generated.
> >
> > It looked like the problem was that genconditions.c did not 
> take into
> > account that the souce file was using windows line endings 
> rather than
> > just \n
> 
> That sounds like a genuine bug that you've found, although it's
> curious that no one else has encountered it (to my knowledge).

  It's probably a cygwin-vs-windoze interaction, and nothing to do with gcc
at all.

  Will, did you either a) unpack the gcc source archive using WinZIP or a
similar windows-based gui app, or b) unpack the sources to a cygwin textmode
mount-point?  These are both known no-nos.

> > Have other people run into this problem?  I fixed it by just having
> > genconditions.c escape \r (although it might have been a better idea
> > to just have it ignore \r)
> 
> I'm not sure whether that's the right fix.  

  I think this situation is almost certainly NAB and need not be fixed.
However, in accordance with the generous-in-what-you-accept principle, maybe
init_md_reader (in gensupport.c) could simply open the source file in
textmode just in case it's been accidentally translated?


    cheers, 
      DaveK
-- 
Can't think of a witty .sigline today....