This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: aggregate_value_p in the gimplifier

On Tue, 2004-07-06 at 20:11, Richard Henderson wrote:
> We want to know if we have an aggregate type that is not returned
> in registers.  We want this for two reasons:

There are two places in gimplify.c that call aggregate_value_p.

The first one is in gimplify_return_expr.  This one looks fine, as this
one is handling RESULT_DECLs.  Your explanation seems to be referring to
this one.

The second one is in gimplify_modify_expr.  This one does not look OK. 
This one just seems to be checking for any aggregate type, to avoid
unnecessary copying of aggregates.  This one has apparently nothing to
do with RESULT_DECLs.  I think this one should be AGGREGATE_TYPE_P
instead.

It is the second one that is causing problems for Eric Botcazou.  This
is because the code is passing to it types which are not valid return
types.
-- 
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]