This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Add 64-bit get_user and __get_user for i386
- From: Linus Torvalds <torvalds at osdl dot org>
- To: Jamie Lokier <jamie at shareable dot org>
- Cc: chris at scary dot beasts dot org, akpm at osdl dot org, linux-kernel at vger dot kernel dot org, gcc at gcc dot gnu dot org
- Date: Mon, 19 Apr 2004 19:42:31 -0700 (PDT)
- Subject: Re: [PATCH] Add 64-bit get_user and __get_user for i386
- References: <20040420020922.GA18348@mail.shareable.org>
On Tue, 20 Apr 2004, Jamie Lokier wrote:
>
> By the way, is there a reason why put_user() is inline when get_user() isn't?
No. It would be good of you to fix put_user(), it should shrink the
kernel.
Only "__get_user()"/"__put_user()" should be inline, since those generally
result in just a single instruction. The range-checking versions are
better off out-of-line, I strongly suspect (but with the special calling
conventions, so that we don't unnecessarily clobber registers etc).
Linus