Re: Do we still need ggc-simple

[Steven Bosscher <steven at gcc dot gnu dot org>]

On Sunday 28 December 2003 19:33, Mark Mitchell wrote:
> On Sun, 2003-12-14 at 02:35, Nick Burrett wrote:
> > Steven Bosscher wrote:
> > > On Wednesday 10 December 2003 11:41, Nick Burrett wrote:
> > >>Steven Bosscher wrote:
> > >>>Why do we still have ggc-simple?  Are there any targets for which
> > >>>ggc-page doesn't work?
> > >>
> > >>Yes (arm-riscos-aof), though it is maintained outside of the GCC tree.
> > >
> > > OK.  So I like bitching.
> > >
> > > Why is arm-riscos-aof not using ggc-page with malloc?
> >
> > Sorry.  The last time I looked to make the decision on using ggc-page or
> > ggc-simple, I figured that ggc-page was a solely mmap implementation.
> > Upon reading the code further, I notice it isn't and therefore I will
> > drop my requirement for ggc-simple.
>
> Based on this discussion, I will pre-approve a patch to remove all
> traces of ggc-simple.c from the mainline.


Like so.

2003-12-28  Steven Bosscher  <steven@gcc.gnu.org>

	* ggc-simple.c: Remove.
	* Makefile.in: Remove ggc-simple.o.
	* configure.in: Disallow --with-gc=simple.
	* configure: Regenerate.

Index: Makefile.in
===================================================================
RCS file: /cvs/gcc/gcc/gcc/Makefile.in,v
retrieving revision 1.1212
diff -c -3 -p -r1.1212 Makefile.in
*** Makefile.in	24 Dec 2003 00:14:17 -0000	1.1212
--- Makefile.in	28 Dec 2003 19:40:16 -0000
*************** gtype-desc.o: gtype-desc.c $(CONFIG_H) $
*** 1466,1474 ****
  ggc-common.o: ggc-common.c $(CONFIG_H) $(SYSTEM_H) coretypes.h $(GGC_H) \
  	$(HASHTAB_H) toplev.h $(PARAMS_H) hosthooks.h
  
- ggc-simple.o: ggc-simple.c $(CONFIG_H) $(SYSTEM_H) coretypes.h $(TM_H) $(RTL_H) $(TREE_H) \
- 	flags.h $(GGC_H) varray.h $(TIMEVAR_H) $(TM_P_H) $(PARAMS_H)
- 
  ggc-page.o: ggc-page.c $(CONFIG_H) $(SYSTEM_H) coretypes.h $(TM_H) $(RTL_H) $(TREE_H) \
  	flags.h toplev.h $(GGC_H) $(TIMEVAR_H) $(TM_P_H) $(PARAMS_H)
  
--- 1466,1471 ----
Index: configure
===================================================================
RCS file: /cvs/gcc/gcc/gcc/configure,v
retrieving revision 1.787
diff -c -3 -p -r1.787 configure
*** configure	22 Dec 2003 07:42:37 -0000	1.787
--- configure	28 Dec 2003 19:40:19 -0000
*************** ac_help="$ac_help
*** 85,91 ****
                            use KEY instead of GCC version as the last portion
                            of the registry key"
  ac_help="$ac_help
!   --with-gc={simple,page,zone} choose the garbage collection mechanism to use
                            with the compiler"
  ac_help="$ac_help
    --with-system-zlib      use installed libz"
--- 85,91 ----
                            use KEY instead of GCC version as the last portion
                            of the registry key"
  ac_help="$ac_help
!   --with-gc={page,zone} choose the garbage collection mechanism to use
                            with the compiler"
  ac_help="$ac_help
    --with-system-zlib      use installed libz"
*************** fi
*** 7649,7655 ****
  if test "${with_gc+set}" = set; then
    withval="$with_gc"
    case "$withval" in
!   simple | page | zone)
      GGC=ggc-$withval
      ;;
    *)
--- 7649,7655 ----
  if test "${with_gc+set}" = set; then
    withval="$with_gc"
    case "$withval" in
!   page | zone)
      GGC=ggc-$withval
      ;;
    *)
Index: configure.in
===================================================================
RCS file: /cvs/gcc/gcc/gcc/configure.in,v
retrieving revision 1.763
diff -c -3 -p -r1.763 configure.in
*** configure.in	22 Dec 2003 07:42:37 -0000	1.763
--- configure.in	28 Dec 2003 19:40:21 -0000
*************** AC_SUBST(gthread_flags)
*** 2689,2698 ****
  
  # Find out what GC implementation we want, or may, use.
  AC_ARG_WITH(gc,
! [  --with-gc={simple,page,zone} choose the garbage collection mechanism to use
                            with the compiler],
  [case "$withval" in
!   simple | page | zone)
      GGC=ggc-$withval
      ;;
    *)
--- 2689,2698 ----
  
  # Find out what GC implementation we want, or may, use.
  AC_ARG_WITH(gc,
! [  --with-gc={page,zone} choose the garbage collection mechanism to use
                            with the compiler],
  [case "$withval" in
!   page | zone)
      GGC=ggc-$withval
      ;;
    *)