This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: Removing -frwitable-strings
On Tue, 23 Dec 2003, Marc Espie wrote:
> I tried that on rogue. I just spent one hour making it const-correct.
> Fortunately, some people had already cleaned up the code quite a bit.
> Contrarily to a previous assertion, the previous security fixes have NOT
> made rogue immune to writable strings. There was still one left in
> throw.c's rand_around...
That one would have been one I fixed five years ago when making the
version I maintain (bsd-games-non-free for Linux) (and the version in
NetBSD) const-correct with -Wwrite-strings (apart from the one file,
rogue/object.c, that remained needing -fwritable-strings until the
security fixes). Having done most of the const-correcting five years ago,
I didn't remember the details of what changes had been needed for
const-correctness beyond just adding the consts.
--
Joseph S. Myers
jsm@polyomino.org.uk