This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: Another issue with diagnostic format-checker
"Kaveh R. Ghazi" <ghazi@caip.rutgers.edu> writes:
> On the issue of where we set GCC_DIAG_STYLE, I lean towards leaving it
> as-is. I.e. have a default in toplev.h, but override it in c-tree.h
> and cp-tree.h, and live with the file ordering issue.
>
> Gaby's solution provides no clean way to apply the appropriate -D flag
> to exactly the right files without introducing problematic changes to
> the Makefiles. (I'm willing to be proven wrong by a clean patch.)
>
> Zack's solution requires us to set GCC_DIAG_STYLE in each and every
> C-family frontend file. There are around 50 of these files.
>
> It's true that we might need to add GCC_DIAG_STYLE to one or two
> frontend files that don't include the appropriate C tree header right
> now, but that's much easier than tweeking every single file.
I have no objection to leaving things as they are. My only interests
in this issue are (a) not going backwards - i.e. not losing format
checking for diagnostic functions; (b) not adding more crap to the
Makefiles.
zw