This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: Analysis of g++.dg/bprob/g++-bprob-1.C multilib failures
On Sun, Dec 29, 2002 at 03:46:30PM -0500, Kaveh R. Ghazi wrote:
> > From: Janis Johnson <janis187@us.ibm.com>
> >
> > On Sat, Dec 28, 2002 at 11:13:14AM -0500, Kaveh R. Ghazi wrote:
> > >
> > > I'm kind of stuck, since this is a maze of dejagnu stuff. If someone
> > > has ideas I would appreciate some help on this one.
> >
> > I wrote the framework for those tests, so perhaps I could figure out
> > what's going on. I've never used multilibs; is that something I could
> > do with a cross compiler (and simulator) on my i686-pc-linux-gnu laptop
> > while I'm at home during the next few days? It's cranking away looking
> > for patches that introduced regressions, but it could be put to work
> > doing something else for a while, and I can interrupt my weaving and
> > papermaking and baking and lazing about to try to remember what those
> > tests are doing.
> > Janis
>
> Thanks Janis, that'll be a big help. While you may be able to
> recreate the error with a multilib simulator, I suspect you may be
> able to use *any* multipass testsuite run. For example, one regular
> (plain vanilla) pass and one -fPIC pass. That would work on a native
> x86-linux-gnu box and should be much simpler since the cross stuff
> won't come into play. If you have the trunk already built and handy,
> as a first guess try:
>
> make RUNTESTFLAGS="--target_board 'unix{-fPIC,-fpic,}'" check-gcc-c++
>
> see if that triggers it for you.
Yes, that did it.
This patch fixes the C++ bprob tests when running the C++ test suite
with multiple sets of options. Those tests were using a global variable
that was also used in other tests, but this change affects only the
outcome of the bprob tests. Tested with the gcc-20021202 snapshot with
and without the patch on i686-pc-linux-gnu with
make RUNTESTFLAGS="--target_board 'unix{-fPIC,-fpic,}'" check-c++
I won't have CVS access for the next few days, so if this looks OK
please check it in.
2002-12-30 Janis Johnson <janis187@us.ibm.com>
* lib/profopt.exp: Change the name of a global variable to avoid
possible clashes with other test suites.
--- testsuite/lib/profopt.exp.orig Sun Dec 29 16:45:07 2002
+++ testsuite/lib/profopt.exp Sun Dec 29 16:45:21 2002
@@ -66,7 +66,7 @@
{ -Os } ]
}
-set option_list $PROFOPT_OPTIONS
+set prof_option_list $PROFOPT_OPTIONS
#
# profopt-cleanup -- remove profiling or performance results files.
@@ -126,7 +126,7 @@
#
proc profopt-execute { src } {
global srcdir tmpdir
- global option_list
+ global prof_option_list
global tool profile_option feedback_option prof_ext perf_ext perf_delta
global verbose
@@ -142,7 +142,7 @@
set executable $tmpdir/[file tail [file rootname $src].x]
set count 0
- foreach option $option_list {
+ foreach option $prof_option_list {
set execname1 "${executable}${count}1"
set execname2 "${executable}${count}2"
set execname3 "${executable}${count}3"