Re: Call for testers for pch-branch

[Geoffrey Keating <geoffk at apple dot com>]

On Tuesday, November 26, 2002, at 04:07  PM, Paolo Carlini wrote:

> Geoffrey Keating wrote:
>
> > The PCH work is now mostly complete, and it would be helpful if it 
> > could have some wider testing, especially on non-Darwin hosts.  So, 
> > if you're interested in precompiled headers, or just want to make 
> > sure that the patches on the branch don't cause regressions on your 
> > favourite host or target, I encourage you to check out the branch and 
> > try it.
> >
> > You can check out and build the branch by doing
> >
> > cvs -d :pserver:anoncvs@subversions.gnu.org:/cvsroot/gcc co -r 
> > pch-branch gcc
> >
> > and then build it using 'configure' and 'make' as usual.
> Hi.
>
> I'm getting a bootstrap error:
>
> ...
> gcc -c   -g  -DIN_GCC   -W -Wall -Wwrite-strings -Wstrict-prototypes 
> -Wmissing-prototypes -Wtraditional -pedantic -Wno-long-long 
> -fno-common  -DHAVE_CONFIG_H    -I. -I. -I../../pch-branch/gcc/gcc 
> -I../../pch-branch/gcc/gcc/. -I../../pch-branch/gcc/gcc/config 
> -I../../pch-branch/gcc/gcc/../include 
> ../../pch-branch/gcc/gcc/dwarf2out.c -o dwarf2out.o
> ../../pch-branch/gcc/gcc/dwarf2out.c: In function `same_dw_val_p':
> ../../pch-branch/gcc/gcc/dwarf2out.c:5687: structure has no member 
> named `id'
> ../../pch-branch/gcc/gcc/dwarf2out.c:5688: structure has no member 
> named `id'
> make[2]: *** [dwarf2out.o] Error 1
> make[2]: Leaving directory 
> `/home/paolo/Gcc/cvs-dirs/pch-branch-build/gcc'
> make[1]: *** [stage1_build] Error 2
> make[1]: Leaving directory 
> `/home/paolo/Gcc/cvs-dirs/pch-branch-build/gcc'
> make: *** [bootstrap] Error 2
Excellent!  This is exactly the sort of thing I was hoping would be 
found.

Does this patch work for you?

*** dwarf2out.c.~1.349.2.15.~   Mon Nov 11 14:14:54 2002
--- dwarf2out.c Tue Nov 26 16:11:58 2002
***************
*** 5684,5691 ****
      case dw_val_class_flag:
        return v1->v.val_flag == v2->v.val_flag;
      case dw_val_class_str:
!       return !strcmp((const char *) HT_STR (&v1->v.val_str->id),
!                    (const char *) HT_STR (&v2->v.val_str->id));

      case dw_val_class_addr:
        r1 = v1->v.val_addr;
--- 5684,5690 ----
      case dw_val_class_flag:
        return v1->v.val_flag == v2->v.val_flag;
      case dw_val_class_str:
!       return !strcmp(v1->v.val_str->str, v2->v.val_str->str);

      case dw_val_class_addr:
        r1 = v1->v.val_addr;