Re: pexecute.c on cygwin for cross compile

[Christopher Faylor <cgf at redhat dot com>]

On Tue, Nov 12, 2002 at 01:02:06PM -0500, DJ Delorie wrote:
>
>Cygwin does have a working fork().  Whether it should use fork or
>spawn is up to the cygwin folks, but it looks like what you propose is
>correct.  Still...
>
>1. Your patch is backwards (should be diff old new, not diff new old)
>2. Please use "cvs diff -p -c 3"
>3. Please include a ChangeLog entry with each patch.

I don't see any reason to special case Cygwin any more, so I think the
correct way to deal with this is to remove all of the if*def CYGWINs
from this file since they are now meaningless.

I don't know what caused the fork error but, since fork is alive and
well in thousands of other programs, it is hard to believe that it is
a generic bug in fork.  If it is, it should definitely be fixed.

cgf

>> 254c254
>> < #if (defined (_WIN32) || defined(__CYGWIN__)) && ! defined (_UWIN)
>> ---
>> > #if defined (_WIN32) && ! defined (_UWIN)
>> 665c665
>> <     && ! ((defined (_WIN32) || defined(__CYGWIN__)) && ! defined (_UWIN))
>> ---
>> >     && ! (defined (_WIN32) && ! defined (_UWIN))