This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: [rfa:ppc] Fix PPC/NBSD struct return; Was: userdef.exp regression for ppc?
On Sun, Jun 02, 2002 at 04:28:59PM -0700, Jason R Thorpe wrote:
> On Sun, Jun 02, 2002 at 04:21:51PM -0700, Zack Weinberg wrote:
>
> > By the way, since you're doing ns32k work: it is one of the last few
> > targets to define PCC_STATIC_STRUCT_RETURN. You almost certainly
> > don't want that (it makes all functions that return structures
> > nonreentrant).
>
> Changing that constitutes an ABI change, right? If so, then I would
> prefer to wait until we (NetBSD) do ELF for ns32k, and then change it
> in that config only.
Sorry, scratch that: ns32k/netbsd.h already overrides the definition
in ns32k/ns32k.h. It may be a concern for vax-netbsd, though.
The PCC_STATIC_STRUCT_RETURN conventions are outright dangerous -
correctly written code silently turns into broken object modules, if
you call structure-returning routines recursively or from independent
threads. I'm contemplating removing them entirely.
zw