This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: GCC build failed for native with your patch on 2002-05-27T20:45:13Z.


On Tuesday 28 May 2002 09:12, Bo Thorsen wrote:
> On Mon, 27 May 2002, Andrew Pinski wrote:
> > avn is still used in ffi_prep_args on line 56.
> > Can you fix this, because you caused it?
>
> !"#%& Sorry about this. I'll fix both lines immediately.

Roger Sayle already fixed this. But as I was fixing it (before I realized it 
had already been done) I found the exact same variable in another place in 
the same file. I already checked it in as obvious in mainline and I'm about 
to check this in to 3.1 branch after bootstrap:

Index: ChangeLog
===================================================================
RCS file: /cvs/gcc/gcc/libffi/ChangeLog,v
retrieving revision 1.48.2.16
diff -u -r1.48.2.16 ChangeLog
--- ChangeLog	28 May 2002 07:05:51 -0000	1.48.2.16
+++ ChangeLog	28 May 2002 07:45:57 -0000
@@ -1,3 +1,8 @@
+2002-05-28  Bo Thorsen  <bo@suse.de>
+
+	* src/x86/ffi.c (ffi_prep_incoming_args_SYSV): Remove avn
+	here too.
+
 2002-05-27  Roger Sayle  <roger@eyesopen.com>
 
 	* src/x86/ffi.c (ffi_prep_args): Remove reference to avn.
Index: src/x86/ffi.c
===================================================================
RCS file: /cvs/gcc/gcc/libffi/src/x86/ffi.c,v
retrieving revision 1.3.8.2
diff -u -r1.3.8.2 ffi.c
--- src/x86/ffi.c	28 May 2002 07:05:52 -0000	1.3.8.2
+++ src/x86/ffi.c	28 May 2002 07:45:57 -0000
@@ -267,7 +267,6 @@
 {
   register unsigned int i;
   register int tmp;
-  register unsigned int avn;
   register void **p_argv;
   register char *argp;
   register ffi_type **p_arg;
@@ -280,35 +279,26 @@
     argp += 4;
   }
 
-  avn = cif->nargs;
   p_argv = avalue;
 
-  for (i = cif->nargs, p_arg = cif->arg_types;
-       (i != 0) && (avn != 0);
-       i--, p_arg++)
+  for (i = cif->nargs, p_arg = cif->arg_types; i != 0; i--, p_arg++)
     {
       size_t z;
 
       /* Align if necessary */
-      if (((*p_arg)->alignment - 1) & (unsigned) argp) {
+      if (((*p_arg)->alignment - 1) & (unsigned) argp)
 	argp = (char *) ALIGN(argp, (*p_arg)->alignment);
-      }
 
-      if (avn != 0) 
-	{
-	  avn--;
-	  z = (*p_arg)->size;
+      z = (*p_arg)->size;
 
-	  /* because we're little endian, this is 
-	     what it turns into.   */
+      /* because we're little endian, this is what it turns into.   */
 
-	  *p_argv = (void*) argp;
+      *p_argv = (void*) argp;
 
-	  p_argv++;
-	  argp += z;
-	}
+      p_argv++;
+      argp += z;
     }
-  
+
   return;
 }
 


-- 

     Bo Thorsen                 |   Praestevejen 4
     Free software developer    |   5290 Marslev
     SuSE Labs                  |   Denmark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]