This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: How to fix AVR progmem type attribute?

On Thu, 23 May 2002, Marek Michalkiewicz wrote:

> > Try explicitly handling TYPE_DECL, and arranging for the type to be
> > modified in that case (using build_type_attribute_variant) rather than the
> > decl.
> Are there any examples (in some other target perhaps) how this should
> be done?  I'm a bit confused...

For example, arm/arm.c:arm_handle_isr_attribute modifies the target type
of a pointer type.

In general, the cases where target attributes apply to both decls and
types should at best have an implementation with table-driven attributes
that is bug-compatible with the old implementation - but it would be a
good idea to go over the exact meaning of the attributes, write testcases
for them, and make sure that the implementation does exactly what's
intended.  (Table-driven attributes are at least as flexible as the old
system; there may be cases where the exact semantics wanted can be better
expressed with them than they were expressed previously.)

The attribute in question also seems to be lacking any documentation.

Joseph S. Myers

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]