This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Bootstrap error with gcc-20020429 snapshot on mips-sgi-irix6.5




--On Wednesday, May 01, 2002 10:08:04 AM -0700 Richard Henderson 
<rth@redhat.com> wrote:

> On Wed, May 01, 2002 at 07:05:26PM +0200, Franz Sirl wrote:
>>        for (p = &weak_decls; (t = *p) ; p = &TREE_CHAIN (t))
>> +	if (DECL_ASSEMBLER_NAME (decl) == DECL_ASSEMBLER_NAME (TREE_VALUE (t)))
>> +	  *p = TREE_CHAIN (t);
>
> This is wrong for iterating over the whole list.  You want
>
> 	for (p = &weak_decls; (t = *p) ;)
> 	  if (...)
> 	    *p = TREE_CHAIN (t);
> 	  else
> 	    p = &TREE_CHAIN (t);

Yup.  This version is OK, for branch and mainline.

--
Mark Mitchell                   mark@codesourcery.com
CodeSourcery, LLC               http://www.codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]