This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix PR c/6343 (was: Re: GCC 3.1 Prerelease)

From: Mark Mitchell <mark at codesourcery dot com>
To: Franz Sirl <Franz dot Sirl-kernel at lauterbach dot com>, Jason Merrill <jason at redhat dot com>
Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Richard Henderson <rth at redhat dot com>, Alan Modra <amodra at bigpond dot net dot au>, "gcc at gcc dot gnu dot org" <gcc at gcc dot gnu dot org>
Date: Sun, 28 Apr 2002 10:56:32 -0700
Subject: Re: [PATCH] Fix PR c/6343 (was: Re: GCC 3.1 Prerelease)
References: <5.1.1.2.2.20020423130143.04a21008@mail.lauterbach.com><200204252121.58902@enzo.bigblue.local><wvlr8l3r1tm.fsf@prospero.cambridge.redhat.com><200204281640.27693@enzo.bigblue.local>

+  if ((! DECL_WEAK (newdecl) && ! DECL_WEAK (olddecl))
+      || (DECL_WEAK (newdecl) && DECL_WEAK (olddecl)))
+    return;
+

Just:

  if (DECL_WEAK (newdecl) == DECL_WEAK (olddecl))
    return;

seems easier to read to me.

+    warning_with_decl (decl, "applying #pragma weak `%s' after first use 
may result in unspecified behaviour");
+

Just say "results in unspecified behavior" or even "is invalid".  There's
no reason to be so cautious; either the construct is legal or it isn't.

OK for mainline and branch with these changes.

Thanks for working so hard on this!

--
Mark Mitchell                   mark@codesourcery.com
CodeSourcery, LLC               http://www.codesourcery.com

References:
- Re: GCC 3.1 Prerelease
  - From: Franz Sirl
- [PATCH] Fix PR c/6343 (was: Re: GCC 3.1 Prerelease)
  - From: Franz Sirl
- Re: [PATCH] Fix PR c/6343 (was: Re: GCC 3.1 Prerelease)
  - From: Jason Merrill
- Re: [PATCH] Fix PR c/6343 (was: Re: GCC 3.1 Prerelease)
  - From: Franz Sirl

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]