This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: fdump-ast-original and strg:



> > "\0122" will work fine.  (Or, in this case, "\n2" assuming ASCII.)
> >
> Yup, you're right. So if you use octal notation to represent a 
> non-printable character and always use 3 octal digits following
> the '\' you have something that should work in all cases.
> 
> > We already have code to emit strings safely, into the assembly output;
> > you could just use that.
> >
> Even better!

Not just "even better", IMHO.  While I'm not the one that will make
a decision about whether a patch is acceptable, I think that any patch
that includes a complete new conversion function should be rejected,
if the option of simply calling an existing string-emitting function
exists.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]