Re: MS Style #pragma pack(push,...)

[Zack Weinberg <zack at wolery dot cumb dot org>]

On Fri, Jun 30, 2000 at 09:25:42AM -0500, Jeremy White wrote:
> [snip]
> > > gcc now handles this almost perfectly (see question #2, below),
> > > but you have to #define HANDLE_PRAGMA_PACK_PUSH_POP in
> > > order to enable this code.
> > 
> > This will be enabled by default for all Linux configurations in gcc
> > 2.96, and may have been there in 2.95 as well.
> > 
> 
> This is not in 2.95.2.  Is 2.96 going to be released soon enough
> that I shouldn't agitate for this in 2.95.3?

Dunno.  It's a simple enough change that it could be safely added to
the branch for 2.95.x, IMO.

> > The new (1999) C standard requires some pragmas _not_ to be macro
> > expanded.  For consistency we'd like all pragmas not to be expanded,
> > unless some overriding concern exists.  This is a valid overriding
> > concern - but what that means is you need to make your patch specific
> > to #pragma pack.
> 
> If I want to get this change into 2.96, should I develop a patch
> against the CVS tip, or is there a branch label I should work from?

You should work from the CVS tip.  You want to wait until the middle
of next week before beginning, as a huge patch is probably going to be
applied on Monday or Tuesday.

zw