Re: Check-In Requirements

[Loren James Rittle <rittle at latour dot rsch dot comm dot mot dot com>]

In article <20000601111146W.mitchell@codesourcery.com> you write:

>+ <li>If your change is to code that is not in a front-end, or is to   
>+     the C front-end, verify that the all of the GCC regression tests
>+     behave identically before and after your patch.   You can do a
>+     <code>make [-k] check</code> at the top of the tree to run all of the
>+     tests.

Could we consider adding some more information in the spirit of good
software engineering practice (it will also help diffuse finger
pointing over ``did X really run the test suite for change Y'')?

After the above quoted section, add:

<li>If your change is to code that is not in a front-end, or is to
    the C front-end, report the results of the GCC regression tests
    with your change.  You can run <code>gcc-src-path/contrib/test_summary
    -m gcc-testresults@gcc.gnu.org | sh</code> at the top of the tree
    in which you ran <code>make -k check</code>.

After the section on changes to non-C-front-ends, add:

<li>If your change is to code that is in a front-end, other than the C
    front-end, report the results of the GCC regression tests with
    your change.  You can run <code>gcc-src-path/contrib/test_summary
    -f -m gcc-testresults@gcc.gnu.org | sh</code> at the top of the
    tree in which you ran <code>make -k check-g++</code> (e.g. for C++
    front-end change).

Change the last bullet section to:

<li>When you post your change to <code>gcc-patches</code>, indicate
    what platform you have used for testing.  That information is
    contained in the e-mail sent to <code>gcc-testresults</code> by
    test_summary, thus you could indicate the message id (or URL in
    the archive) of the related GCC regression tests result you posted.
-- 
Loren J. Rittle
Staff Software Engineer, Distributed Object Technology Lab
Networks and Infrastructure Research Lab (IL02/2240), Motorola Labs
rittle@rsch.comm.mot.com, KeyID: 2048/ADCE34A5, FDC0292446937F2A240BC07D42763672