This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: your recent patch to cpplib.c
- To: zack at wolery dot cumb dot org
- Subject: Re: your recent patch to cpplib.c
- From: Mark Mitchell <mark at codesourcery dot com>
- Date: Tue, 08 Feb 2000 17:12:59 -0800
- Cc: gcc at gcc dot gnu dot org
- Organization: CodeSourcery, LLC
- References: <20000208141259.I7478@wolery.cumb.org>
I didn't see a gcc-patches message for this:
I apologize for that. Our mail server was very badly behaved
yesterday -- it dropped outgoing mail without telling me! I'm still
trying to figure out who got what.
I posted a test-case with the bug. It was, I belive:
#define f(x) x
void g() {
f
(3);
}
The CPP output compressed `g' to one line.
The right fix is not to use the mark at all in this context. It's
supposed to be for lookahead under extremely limited circumstances and
this isn't one of them. (And it will probably vanish entirely in the
parser rewrite.)
On the other hand, congratulations; you have probably found the line
numbering bug I've been looking for for months.
Well, that's something. I apologize for the bogus fix. What should
we do at this point?
I've not got the time to do the complete fix, I don't think. But, I
can certainly back out my change, or we can leave it in. Let me know
what you would like.
And thanks for explaining this.
--
Mark Mitchell mark@codesourcery.com
CodeSourcery, LLC http://www.codesourcery.com